https://gitlab.synchro.net/main/sbbs/-/commit/c0ef762adf57ff91307c3015
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Remove defunct files from batch download queue during logon

If a user doesn't have access to download a file that's in their batch queue, remove it without saying anything to the user (but log a notice-level message about it) during logon. Files that no longer exist in the filebase are treated the same way.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8266da9c329d2ba49ff2001c
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Log an error if getstats() returns a failure

I saw my logon.jsonl file getting cycled multiple times a day recently on Vert and suspect this function call may have been failing.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e12c35049251dc97e8eafd7c
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Revert "Log an error if getstats() returns a failure"

This reverts commit 8266da9c329d2ba49ff2001cf542a0d05dc9987e.

We're already passing a sock_init callback (ls_cb) which is supposed to set
the socket options (call set_socket_options), so this change shouldn't be necessary and reportedly caused more issues binding ircd sockets when running ircd.js via jsexec (though I didn't see this myself).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/46f1f80e75b30d477cdb419c
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Revert "Revert "Log an error if getstats() returns a failure""

This reverts commit e12c35049251dc97e8eafd7c7fc12dfd9ba13ad9.

Wrong commit reverted. Oops.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/65f1df280bc72439e80b8a9f
Modified Files:
src/sbbs3/logon.cpp
Log Message:
A todo comment

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cbf6a8b24c615e753801dbd2
Modified Files:
src/sbbs3/logon.cpp
Log Message:
I'm not sure what "node message indices" (data/msgs/*.ixb files) are/were

I don't recall this actually being a thing, ever, so certainly no reason to
be cleaning these files up during logon. <shrug>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f315f34ce2c8b91e656fc5a4
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Change "On two nodes" to "On more than one node", since it's possible it's > 2

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9544a3c6bf36555a2babc6bb
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Don't send NodeLoggedOn message to any nodes if user isn't being logged-on

If user is being kicked off for being on "More than one node at a time", then don't send a message to other any other nodes that the user logged-on successfully (they haven't). Previosuly, it'd send messages to all the lower-numbered nodes that were in-use (but not by the same user).

Reported by Nelgin.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c345c6ad034f1e64db2b88de
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Clear the Guest user's language (lang) field during logon - revert to default

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3bcf61744225d8898eae6a00
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Always close csts.ini file, even in error path (failure to open dsts.ini)

Fix for CID 509720

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/69e23e724e4e9dd2cd905b7d
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Move the backup of dsts.ini before opening the file

Can't backup (make copies of) an open file.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3b602ca5349f2b4143ff27ab
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Check return value of getnodedat()

Should fix CID 515599 since this seems to be the only place we call unlocknodedat() without possibly not owning the nodefile_mutex already.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net