https://gitlab.synchro.net/main/sbbs/-/commit/fb957d1d8844368b19fb5b16
Modified Files:
src/sbbs3/js_file.c
Log Message:
Increase size of file mode string so it's not 4 bytes.

4-bytes is how bit a 32-bit pointer is.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7dcfa20fe2f1ce9eb52a3ba1
Modified Files:
src/sbbs3/js_file.c
Log Message:
Don't convert/store small integers to doubles when reading/writing .ini files

Fix issue #760

UINT_TO_JSVAL automatically handles the storage as the necsesary underlying type in the JS engine.

Values > 0x7fffffff (2147483647) will still be stored (and re-written) as doubles and could be problematic.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/105627890fa49ca6a6198408
Modified Files:
src/sbbs3/js_file.c
Log Message:
Eliminte weird gcc (12.2) warning in release build (only)

Increasing size of mode[] element by 2 bytes eliminated these GCC warnings
that seem like false-positives to me:

sbbs.h:194:48: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
194 | (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
| ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
js_file.c:225:25: note: in expansion of macro `JSSTRING_TO_STRBUF'
225 | JSSTRING_TO_STRBUF(cx, str, p->mode, sizeof(p->mode), NULL);
| ^~~~~~~~~~~~~~~~~~
js_file.c:42:17: note: at offset 5 into destination object `mode' of size 5
42 | char mode[5];
| ^~~~

Similar use of JSSTRING_TO_STRBUF in other files (js_console.cpp, js_archive.c) (with larger target buffers) does not trigger the same warnings.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6ba59a06b546c1ed0e3b2b8b
Modified Files:
src/sbbs3/js_file.c
Log Message:
Add missing NULL pointer check to js_iniReadAll()

iniReadFile() can return NULL upon file read error or malloc error. Let's not crash if that happens.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5e1087e457db2b41dab45deb
Modified Files:
src/sbbs3/js_file.c
Log Message:
File.read() encodes base64, it doesn't decode.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b580def0507913d01bd70cea
Modified Files:
src/sbbs3/js_file.c
Log Message:
Fix spurious call to JS_THIS_OBJECT()

This appears to be why valgrind on FreeBSD was failing.
You can't actually call this in a constructor because creating
this is the whole point of calling it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d474410052e6d6022d2b3af4
Modified Files:
src/sbbs3/js_file.c
Log Message:
Use iniGetSectionList() instead of iniReadSectionList()

... in File.iniGetSections() method

because iniReadSectionList() doesn't recognize !include directives.

This fixes issue #871 whereby modopts.js couldn't find sections in modopts.d/*.ini files.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net